teleo/teleo-infrastructure
8
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions 1

fix(activity-feed): emit Forgejo pr_url fallback so every event has a clickthrough #12

Merged
fwazb merged 1 commit from fix/forgejo-pr-url-fallback into main 2026-05-13 04:40:38 +00:00
Conversation 0 Commits 1 Files changed 1 +27 -7
fwazb commented 2026-05-13 04:40:32 +00:00
Owner
Copy link

Previously _github_pr_url() only returned a URL when prs.github_pr was
populated. That field is set on only 3 of 4094 merged PRs (the rare cases
mirrored to the public GitHub repo), so pr_url was null for ~100% of the
feed. The frontend whole-row PR overlay (livingip-web PR #30) renders
only when pr_url is non-null, so until now no rows had the overlay.

Pipeline-attributed events (reweave/, ingestion/) are the most visible
victim: their /contributors/pipeline link lands on a sparse stub, with
no way to reach the actual commit/PR they refer to.

Fix: rename _github_pr_url -> _pr_url and fall back to the canonical
Forgejo URL (git.livingip.xyz/teleo/teleo-codex/pulls/{number}) when no
GitHub mirror exists. Verified 200 OK against a sample (#10568). GitHub
URL still wins when available.

Result: 1972/1972 events in _build_events now carry a pr_url. Whole-row
overlay starts working for everything including pipeline events.

Previously _github_pr_url() only returned a URL when prs.github_pr was populated. That field is set on only 3 of 4094 merged PRs (the rare cases mirrored to the public GitHub repo), so pr_url was null for ~100% of the feed. The frontend whole-row PR overlay (livingip-web PR #30) renders only when pr_url is non-null, so until now no rows had the overlay. Pipeline-attributed events (reweave/*, ingestion/*) are the most visible victim: their /contributors/pipeline link lands on a sparse stub, with no way to reach the actual commit/PR they refer to. Fix: rename _github_pr_url -> _pr_url and fall back to the canonical Forgejo URL (git.livingip.xyz/teleo/teleo-codex/pulls/{number}) when no GitHub mirror exists. Verified 200 OK against a sample (#10568). GitHub URL still wins when available. Result: 1972/1972 events in _build_events now carry a pr_url. Whole-row overlay starts working for everything including pipeline events.
fwazb added 1 commit 2026-05-13 04:40:32 +00:00
fix(activity-feed): emit Forgejo pr_url fallback so every event has a clickthrough
Some checks failed
CI / lint-and-test (pull_request) Has been cancelled
Details
e78308862a 
Previously _github_pr_url() only returned a URL when prs.github_pr was
populated. That field is set on only 3 of 4094 merged PRs (the rare cases
mirrored to the public GitHub repo), so pr_url was null for ~100% of the
feed. The frontend whole-row PR overlay (livingip-web PR #30) renders
only when pr_url is non-null, so until now no rows had the overlay.

Pipeline-attributed events (reweave/*, ingestion/*) are the most visible
victim: their /contributors/pipeline link lands on a sparse stub, with
no way to reach the actual commit/PR they refer to.

Fix: rename _github_pr_url -> _pr_url and fall back to the canonical
Forgejo URL (git.livingip.xyz/teleo/teleo-codex/pulls/{number}) when no
GitHub mirror exists. Verified 200 OK against a sample (#10568). GitHub
URL still wins when available.

Result: 1972/1972 events in _build_events now carry a pr_url. Whole-row
overlay starts working for everything including pipeline events.
fwazb merged commit aaab659900 into main 2026-05-13 04:40:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: teleo/teleo-infrastructure#12
No description provided.
Delete branch "fix/forgejo-pr-url-fallback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?