7bb6fc417b
Some checks are pending
CI / lint-and-test (push) Waiting to run
* feat(kb): apply_proposal engine to land approved proposals into canonical Stage 2 of the KB apply pipeline (approve -> APPLY -> render -> surface). Turns an approved kb_stage.kb_proposals row into canonical public.* rows and flips the ledger to 'applied' in one verified transaction. - Connects as the narrow kb_apply role (never superuser): writes only strategies, strategy_nodes, claim_evidence, claim_edges + kb_proposals ledger. Enforces "agents propose, do not self-apply" at the DB boundary. - Per-type handlers: revise_strategy (versioned strategy + node replace), add_edge, attach_evidence (requires existing source_id; source minting is intentionally out of scope for kb_apply's grants). - Strict apply_payload contract (v1); freeform eval packets are normalized upstream, not applied directly. - --dry-run prints exact SQL; idempotent (refuses non-approved / already-applied); transactional with an in-txn DO-block invariant check that rolls back on failure. - Unit tests cover SQL builders, validation, dispatch, and status guards. * fix(kb): rowcount=1 apply guard + real applied_by FK stamp Closes the three draft-exit review items on the apply engine: - Ledger flip now runs in a DO block asserting exactly one 'approved' row moved to 'applied' (GET DIAGNOSTICS row_count). Closes the concurrent double-apply race — load_proposal (read) and the flip (write) are separate statements, so a row lock cannot span them; only one concurrent apply can match status='approved', so rowcount=1 is the authoritative guard. A loser RAISEs and the whole txn rolls back. - applied_by_agent_id is stamped as a real FK resolved from public.agents by handle, defaulting to the kb-apply service agent — no more NULL FK, no backfill needed. - scripts/kb_apply_prereqs.sql: one-time superuser bootstrap — inserts the kb-apply service-agent row (kb_apply never gets INSERT on agents), grants kb_apply SELECT on public.agents, and ensures the one-active-strategy unique index (idempotent; already present on prod). 18/18 unit tests pass. * fix(kb): hard-resolve applied_by handle, RAISE on NULL FK Resolve applied_by into a variable and assert NOT NULL before the ledger flip, instead of an inline subselect that silently stamps a NULL applied_by_agent_id on an unresolved handle. Since the FK is ON DELETE SET NULL, a bad handle (typo/unseeded agent) was a legal silent NULL -- the perpetually-NULL FK we eliminated. Unresolved handle now hard-fails -> rollback. Non-default --applied-by (operator, future drafters) is the path that goes through the lookup and could strand NULL. |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| conftest.py | ||
| test_activity_classify.py | ||
| test_agent_graph_schema_sql.py | ||
| test_agent_routing.py | ||
| test_apply_proposal.py | ||
| test_attribution.py | ||
| test_contributor.py | ||
| test_decision_engine_replay.py | ||
| test_enrichment_dedup.py | ||
| test_entity_queue.py | ||
| test_eval_actions.py | ||
| test_eval_parse.py | ||
| test_eval_pipeline.py | ||
| test_evaluate_agent_routing.py | ||
| test_extraction_prompt.py | ||
| test_feedback.py | ||
| test_install_telegram_agent_token.py | ||
| test_install_telegram_smart_research_gates.py | ||
| test_leaderboard.py | ||
| test_merge.py | ||
| test_phase1b_end_to_end.py | ||
| test_post_extract.py | ||
| test_pr_state.py | ||
| test_research_backfill_idempotent.py | ||
| test_research_eval_schema_sql.py | ||
| test_reweave.py | ||
| test_reweave_merge.py | ||
| test_search.py | ||
| test_telegram_leo_wallet_test_runtime.py | ||
| test_telegram_leo_x402_bridge.py | ||
| test_teleo_agent_healthcheck.py | ||
| test_teleo_agent_systemd.py | ||
| test_tg_batching.py | ||
| test_x_content_pipeline.py | ||